Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Makefile): Use go run for possible tools #1649

Conversation

nderjung
Copy link
Member

Use native go run for external tools which are used for
static checks, tests and more. Remove installation-type
targets.

Signed-off-by: Alexander Jung [email protected]

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

Use native `go run` for external tools which are used for
static checks, tests and more.  Remove installation-type
targets.

Signed-off-by: Alexander Jung <[email protected]>
Copy link
Member

@craciunoiuc craciunoiuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here. Thanks!

Reviewed-by: Cezar Craciunoiu [email protected]
Approved-by: Cezar Craciunoiu [email protected]

@craciunoiuc craciunoiuc merged commit 6bc6fc4 into unikraft:staging May 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants